Run processes in background#731
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #731 +/- ##
==========================================
- Coverage 79.20% 78.78% -0.43%
==========================================
Files 33 34 +1
Lines 5112 5171 +59
==========================================
+ Hits 4049 4074 +25
- Misses 1063 1097 +34 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Looking for some feedback on this PR. Interested in what features you guys think should be added or what already needs to be changed. |
Merge branch 'dev' into jt-711-r_bg # Conflicts: # R/mod_downloadHandler.R
Merge branch 'dev' into jt-711-r_bg # Conflicts: # NEWS.md # R/mod_downloadHandler.R
AARON-CLARK
left a comment
AARON-CLARK
left a comment
There was a problem hiding this comment.
Hi @Jeff-Thompson12,
This is pretty sweet! In my first test, I ran html reports for 3 reports, then 5 reports. When downloading 3 reports, I noticed I was still able to do things in the app, which was not expected. Is that normal?
When rendering 5 reports, I was able to download a new package to the db while it was running, which is amazing. However, when it finished, the app crashed and there was an error in the console:
Merge branch 'dev' into jt-711-r_bg # Conflicts: # DESCRIPTION # NEWS.md # R/mod_downloadHandler.R
Merge branch 'dev' into jt-711-r_bg # Conflicts: # NEWS.md
|
@aclark02-arcus something else I forgot to mention is that since downloading a report is now a separate event from the report creation it is possible for the report downloader or another user to change outputs. This could be as low risk as adding comments but could also include actions like deleting a package from the database, which now that I mention it could crash the app. |
|
Converting to draft while we consider some alternatives, like grabbing info from database and injecting it into a list for rendering all our reports. If we can strip out the riskmetric layout "things", it may become really efficient too. |
4 participants
Addresses #711